search

coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.
Apache License 2.0
123 stars 24 forks source link

feat: push final image to cache repo #197

Closed mafredri closed 2 months ago

mafredri commented 3 months ago

This commit enables pushing the final image to the given cache repo.a As part of #185, the goal is to allow for faster startup when the image has already been built.

mafredri commented 3 months ago

I vote for making it optional and convert it into a full review.

Let's call this a blocker for merging this PR for now. It's a bit soon to decide how we want to expose this as new configuration options.

I had anyway planned to hold off on a decision here until #186 is complete and we have a better picture of how we want to implement #128.

johnstcn commented 2 months ago

@dannykopping @mtojek I think this one is orthogonal to https://github.com/coder/envbuilder/pull/213 but I just want to make sure before closing. I have some tests added just in case.

johnstcn commented 2 months ago

Closing this as a duplicate of https://github.com/coder/envbuilder/pull/213/