chore: integration: add test for pushing to cache repo that requires auth

coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.

Apache License 2.0

111 stars 23 forks source link

chore: integration: add test for pushing to cache repo that requires auth #233

Closed johnstcn closed 1 month ago

johnstcn commented 1 month ago

Addresses a gap in our testing for the case when the cache repo requires auth. NOTE: this shows that being unable to push the image will fail the build outright. Do we maybe want to relax this?

johnstcn commented 1 month ago

The pushed image is just an optimization to speed up the subsequent runs, correct? It feels like Principle of Least Surprise here would be to complete the primary objective (which is building), and any ancillary steps to optimize should not fail that.

As a counterpoint, I can foresee this being used in a CI scenario along with something like ENVBUILDER_INIT_SCRIPT=exit 0 in order to 'pre-warm' the cache repo. I'm not sure which behaviour is most desirable here.