search

coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.
Apache License 2.0
111 stars 23 forks source link

Update README.md #239

Closed paviln closed 2 weeks ago

paviln commented 1 month ago

Hello,

It seems like ENVBUILDER_GIT_USERNAME/PASSWORD is not used, and GIT_USERNAME/PASSWORD works.

Can someone explain why that is?

If this is a mistake in docs, it can be updated by this pull request.

matifali commented 3 weeks ago

@paviln Hi, you are right about the difference in variable names. envbuilder's main branch uses the new ENVBUILDER_ names, but it has not been published yet, and the last published version v0.2.9 does not support it.

It should be fixed when a new version of envbuilder is published.

ggjulio commented 2 weeks ago

I was fooled by the readme too.

There are other files to update as well

BrunoQuaresma commented 2 weeks ago

Hey folks, the main version of envbuilder uses the ENVBUILDER prefix for the env variables so all the README is using it and we plan to keep it. For now, you can use the README from the latest published version here https://github.com/coder/envbuilder/tree/v0.2.9.

johnstcn commented 2 weeks ago

See also https://github.com/coder/envbuilder/releases/tag/v1.0.0-rc.0