search

coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.
Apache License 2.0
142 stars 26 forks source link

Use a deterministic target path for feature dir mounts with useBuildContexts #247

Closed aaronlehmann closed 3 months ago

aaronlehmann commented 3 months ago

This avoids caching issues when using the Dockerfile produced in useBuildContexts mode. See https://github.com/coder/envbuilder/pull/205#issuecomment-2181962174 for context.

aaronlehmann commented 3 months ago

Works for me! I've changed the prefix to /.envbuilder/features. I went ahead and hardcoded this because this package won't be able to import the root envbuilder package, but let me know if you prefer to pass in MagicDir instead.

kylecarbs commented 3 months ago

I think duplicating it is fine!

kylecarbs commented 3 months ago

@aaronlehmann feel free to merge whenever!

aaronlehmann commented 3 months ago

Thanks!