coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.
Apache License 2.0
111 stars 23 forks source link

Envbuilder create git repo folder with a trailing `.git` #252

Open ggjulio opened 2 weeks ago

ggjulio commented 2 weeks ago

It seem that the function here does not work as expected : https://github.com/coder/envbuilder/blob/8c5c50cad3ae396b73619d36da43ef2ff0ac0be8/envbuilder.go#L966

When fixed, the workaround in templates like AWS (devcontainer) could be removed I guess. https://github.com/coder/coder/blob/0a221e8d5b75be449011e499a023c1304284e50a/examples/templates/aws-devcontainer/main.tf#L83

Reproduction

I used the devcontainer-kubernetes with almost no modifications.
(only added auth for git + a few modules )