fix(remount): correct usrLibMultiarchDir value for 32-bit ARM

coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.

Apache License 2.0

111 stars 23 forks source link

fix(remount): correct usrLibMultiarchDir value for 32-bit ARM #259

Closed maxbrunet closed 1 week ago

maxbrunet commented 2 weeks ago

This constant is for 64-bit systems. 32-bit ARM is not supported. If ever it becomes supported, it should be handled with a usrLib32MultiarchDir constant.

Using /var/empty for unsupported directories like NVIDIA: https://github.com/NVIDIA/libnvidia-container/blob/v1.15.0/src/common.h#L53

Follow up to #258

maxbrunet commented 1 week ago

This directory will never exist as far as I can tell on a 32-bit ARM system. I'm not sure what the wider ramifications of that would be?

Correct, it will never match as a prefix, so nothing should happen. And /usr/lib64 should never appear on a 32-bit system either