search

coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.
Apache License 2.0
130 stars 25 forks source link

chore: refactor options to separate package #278

Closed johnstcn closed 1 month ago

johnstcn commented 1 month ago

Part of https://github.com/coder/team-coconut/issues/11 Extracts Options to its own package to support easier importing from separate repositories.

johnstcn commented 1 month ago

I would suggest skipping the pkg prefix, otherwise LGTM. 👍🏻 We already have some packages, like devcontainer that would make sense to have on the same level IMO.

Fair enough. I only chose /pkg/ due to it being a commonly-used prefix, but we can strip it.

mafredri commented 1 month ago

Fair enough. I only chose /pkg/ due to it being a commonly-used prefix, but we can strip it.

True, it's not totally uncommon, but it's a bit controversial. Also considered "legacy" https://x.com/bradfitz/status/1039512487538970624 by some 😄