URLParams option should take a string instead

coder / hat

HTTP API testing for Go

MIT License

37 stars 3 forks source link

URLParams option should take a string instead #21

Closed nhooyr closed 4 years ago

nhooyr commented 6 years ago

If they want to use url.Values, they can, and then encode.

It just makes the API really verbose if they just want to encode a few simple parameters.

ammario commented 5 years ago

If they want to provide params that way, they can just append to the path?

nhooyr commented 5 years ago

Should be documented that works. Seems unexpected imo to call it a path then when it's really a URL. At that point, we don't even need the URLParams option.

nhooyr commented 4 years ago

Going to close as it has been a long time and I'm not sure if this is relevant anymore.