search

coder / images

Example Docker images for use with Coder
https://hub.docker.com/r/codercom/enterprise-base
Other
96 stars 37 forks source link

move to coder/images #275

Open matifali opened 5 months ago

matifali commented 5 months ago

I am unfamiliar with why these images are called enterprise-xxx. We should probably rename the repo and images to coder/images. We can keep the legacy images on dockerhub and publish the new ones ghcr.io

The idea is to have something like coder/modules and coder/templates and integrate with https://registry.coder.com where we can list images too. We can also accept community contributions for templates and images as we do with modules and list on our registry.

cc: @bpmct

johnstcn commented 5 months ago

While we're at it, I'd like to change the naming scheme:

This might entail some shuffling things around on-disk.

PraveenkumarLilly commented 4 months ago

Hi Team, I want to use nvidia base image for a template to perform some Deep learning and GPU based tasks. I have build the docker image with base nvidia/cuda:12.2.0-base-ubuntu22.04 and on top of that I have added curl and wget to run startup scripts and to download some dependencies. When I use that image in the template, While I'm launching the workspace I'm not able to launch it.

Please help me in this issue. Thanks.

matifali commented 4 months ago

The scope of the images in this repo does not cover every use case. cc: @bpmct

Hi, @PraveenkumarLilly. To use GPU, you also need a few other steps; please look at the deep learning templates and the source code for dockerdl images below to get the idea.

  1. https://github.com/matifali/coder-templates
  2. https://github.com/matifali/dockerdl
ericpaulsen commented 4 months ago

hi @PraveenkumarLilly - if you are having issues with Coder or Coder workspaces, we recommend you open an issue in #coder/coder

PraveenkumarLilly commented 4 months ago

Hi @matifali, Thanks for replying back, We are using Kubernetes based template. Can you share Nvidia base GPU image in Kubernetes?

PraveenkumarLilly commented 4 months ago

Hi @ericpaulsen, Sure, Eric I'll do that

Thanks.

matifali commented 1 week ago

While we're at it, I'd like to change the naming scheme:

  • images/base/ubuntu.Dockerfile -> ubuntu:base
  • images/minimal/ubuntu.Dockerfile -> ubuntu:minimal
  • images/$IMAGE/$DISTRO.Dockerfile -> $DISTRO:$IMAGE

This might entail some shuffling things around on-disk.

@jatcod3r, We are going to adopt the above convention for naming new and old images.

bpmct commented 1 week ago

I like the new convention 👍🏼

bpmct commented 1 week ago

I renamed the repo.

bpmct commented 1 week ago

Can someone else help with the repo/image/pipeline format?

matifali commented 1 week ago

@johnstcn, do you also want images to be renamed or only the directory structure?

For images codercom/enterprise-base --> codercom/base?

johnstcn commented 1 week ago

@johnstcn, do you also want images to be renamed or only the directory structure?

For images codercom/enterprise-base --> codercom/base?

I'm fine with keeping the current names of the published images. Renaming them would be a bit more involved and require communications. If we really feel like we want to rename the published images as well, we could dual-publish under both naming conventions with a deprecation period.

bpmct commented 1 week ago

Huge fan of dual-publishing so we have a nice clean image for new users/examples. Down the road, we could use a motd or something to let people know we'll stop dual-publishing

matifali commented 1 week ago

We plan to publish new images on ghcr. Will add a MOTD to dockerhub ones and then stop them eventually