coder / modules

A collection of Terraform Modules to work with Coder.
https://registry.coder.com
Apache License 2.0
23 stars 19 forks source link

Web RDP module with devolutions-gateway #234

Closed bpmct closed 1 day ago

bpmct commented 2 months ago

I have validated a web RDP client called devolutions-gateway which works well inside coder workspaces as a coder_app. See RFC

Screenshot 2024-04-23 at 10 57 09 AM

You can see the WIP here: https://github.com/coder/modules/tree/web-rdp/windows-rdp. You can also try it in dogfood: https://dev.coder.com/templates/windows-with-good-rdp

However, the web app for the client itself requires a "log in," which in Coder's case is not necessary because the template can run the app in loopback and the Coder workspace proxy serves as the authentication mechanism (similar to how we pass auth=none to code-server). As far as I could tell, there is no way to hardcode credentials or pass them via a URL parameter. There is a way to pass a custom static site so that we do not need to fork gateway itself.

WebRDP module Angular component of Devolutions Gateway WebRDP Dogfood Template

Must have

Should have

Nice to have

michaelbrewer commented 2 months ago

Very cool. Would like to see how to run this within a kubernetes cluster too.

bpmct commented 2 months ago

Sadly, Windows containers do not support a desktop environment as far as I can tell. I think VMs are the only route, but something like Kubevirt could be used to manage VMs via the Kubernetes API.

bpmct commented 1 week ago

We also need to test this on AWS and Azure before merging and edit the README

Parkreiner commented 1 week ago

@bpmct Wanted to double-check your thoughts on hiding the top bar for RDP. It feels handy to me, but if you think it should go, it's going to take me three lines of code to hide it. Not a problem at all to get the file changed

Kira-Pilot commented 1 day ago

Kirby to reach out to Ben regarding release timing and Azure support - this is the last remaining piece of work aside from the open PR.

Kira-Pilot commented 1 day ago

We'll want to follow-up with an internal note in this ticket when this is released: https://coder.zendesk.com/agent/tickets/2927