search

coder / modules

A collection of Terraform Modules to work with Coder.
https://registry.coder.com
Apache License 2.0
23 stars 19 forks source link

feat(vscode-web): add offline, use_cached, extensions_dir and auto_install_extensions #235

Closed michaelbrewer closed 2 months ago

michaelbrewer commented 2 months ago
michaelbrewer commented 2 months ago

I think I have suggested all the name changes, but I could have missed some.

some of this was there from before and some of it was exactly working code from the code-server implementation. I have accepted all your suggestions, but i will need to retest and fix CI errors.

matifali commented 2 months ago

Thank you, @michaelbrewer ❤️ . You are doing a great job of making modules super helpful.

Let's wait for an approval from @code-asher and I will merge and cut a release.

michaelbrewer commented 2 months ago

Thank you, @michaelbrewer ❤️ . You are doing a great job of making modules super helpful.

Let's wait for an approval from @code-asher and I will merge and cut a release.

Would be nice to have official templates is composed of modules. :)

matifali commented 2 months ago

Would be nice to have official templates is composed of modules. :)

I have also thought about this and created an issue. But Coder bundles starter templates within the product and when we add modules that are fetched from registry, this does not work on restricted or air-gapped deployments.

michaelbrewer commented 2 months ago

Would be nice to have official templates is composed of modules. :)

I have also thought about this and created an issue. But Coder bundles starter templates within the product and when we add modules that are fetched from registry, this does not work on restricted or air-gapped deployments.

Most of the included examples don't run air-gapped as they would curl to install code-server.

Maybe https://developer.hashicorp.com/terraform/language/providers/requirements#source-addresses to allow for registry.coder.com ?

michaelbrewer commented 2 months ago

Scanning through the examples you can see cases of this: