search

coder / modules

A collection of Terraform Modules to extend Coder templates.
https://registry.coder.com
Apache License 2.0
29 stars 26 forks source link

Add open_recent option to VS Code desktop #248

Closed code-asher closed 4 months ago

code-asher commented 4 months ago

Together with https://github.com/coder/vscode-coder/pull/272 closes https://github.com/coder/vscode-coder/issues/241

This also (accidentally) fixes what I would imagine is a bug where if there is no folder, it would exclude the URL.

matifali commented 4 months ago

@code-asher this will only work when using the VS Code desktop module. Do we need to do something to also support this with the Coder built-in VSCode desktop button?

code-asher commented 4 months ago

Do we need to do something to also support this with the Coder built-in VSCode desktop button?

I asked the same question here: https://github.com/coder/vscode-coder/issues/241#issuecomment-2113600314

I am not sure if we have any way to customize the built-in button so I think we would have to either make this the default or add options for this, but I feel like we should encourage folks to use the module anyway.

code-asher commented 4 months ago

We decided to make openRecent the default for the built-in app. I think that makes sense, since you cannot configure folder for that one anyway (it always uses the agent directory, I believe).