search

coder / modules

A collection of Terraform Modules to work with Coder.
https://registry.coder.com
Apache License 2.0
29 stars 24 forks source link

jupyter lab install path not flexible #275

Open michaelbrewer opened 1 month ago

michaelbrewer commented 1 month ago

When installing jupyter via pip3 install --upgrade --no-cache-dir --no-warn-script-location jupyterlab , the install path may not be in $HOME/.local/bin/jupyter which run.sh current depends.

A solution could be to provide a parameter to the fully qualified path.

matifali commented 1 month ago

When installing jupyter via pip3 install --upgrade --no-cache-dir --no-warn-script-location jupyterlab , the install path may not be in $HOME/.local/bin/jupyter

When is this possible? I have not seen this yet.

We can make the path an input to the module to support/fix cases affected by the assumption.

michaelbrewer commented 1 month ago

the script assumes that the jupyter exec in located in $HOME/.local/bin/jupyter but this won't always be true.

So when it tests command -v jupyterlab it does a pip3 install --upgrade --no-cache-dir --no-warn-script-location jupyterlab but then jupyter might be installed in a python shim.