search

coder / modules

A collection of Terraform Modules to extend Coder templates.
https://registry.coder.com
Apache License 2.0
33 stars 34 forks source link

feat(vscode-web): support hosting on a subpath with `subdomain=false` #288

Closed Emyrk closed 1 month ago

Emyrk commented 2 months ago

Requires https://github.com/coder/coder/issues/14483

matifali commented 1 month ago

@Emyrk Do you plan to come back to this? A similar approach is used in #316 and #320.

Emyrk commented 1 month ago

@matifali I think this has be done for it to work https://github.com/coder/coder/issues/14483

I see the Juypter accomplishing this by setting the url to the full path, but I thought I tried that and it did not work for this.

matifali commented 1 month ago

@Emyrk A Community member successfully ran Jupyter on a subpath by setting the full URL. See #313

Emyrk commented 1 month ago

@Emyrk A Community member successfully ran Jupyter on a subpath by setting the full URL. See #313

I do see that. I think it depends on how urls are constructed within the app. I am pretty sure I tried this with VSCode and it did not. Using the exact same technique.

If someone has more time to try it, please do.

matifali commented 1 month ago

@code-asher @Emyrk I tested with both subdomain=true|false and it works. Also, I have noticed that skipping the coder_agent's name auto updates the URL with the correct agent_name, so it is not necessary.

We can drop agent_name from all modules that support subdomain=false.