search

coder / modules

A collection of Terraform Modules to extend Coder templates.
https://registry.coder.com
Apache License 2.0
33 stars 33 forks source link

fix(filebrowser): only require agent_name when not on subdomain #299

Closed matifali closed 1 month ago

matifali commented 1 month ago

Ensure that agent_name defaults to an empty string, and introduce validation to require it when subdomain is true. This aligns with expected behavior and prevents misconfiguration.

generated by aicommit

phorcys420 commented 1 month ago

hey @matifali, couldn't we just grab it somehow from the agent id, or pass the full agent object instead of the id? i'll still review l8r though ;-)

matifali commented 1 month ago

@phorcys420 We do not have any way to get the agent name from the id within Terraform yet. We are using the same approach in https://registry.coder.com/modules/jetbrains-gateway module