search

coder / modules

A collection of Terraform Modules to extend Coder templates.
https://registry.coder.com
Apache License 2.0
33 stars 33 forks source link

feat(jupyterlab): add support for `subdomain=false` #316

Closed framctr closed 1 month ago

framctr commented 1 month ago

Resolves #313

framctr commented 1 month ago

I changed also the prints in the run.sh to be compatible with /bin/sh according to https://www.shellcheck.net/wiki/SC2028

matifali commented 1 month ago

Hi @framctr, do you plan to finish this? If not, I can help complete this. Thank you :)

framctr commented 1 month ago

@matifali As I said previously, I cannot verify with subdomain=true and for this reason, I didn't update anything more. If you can verify this it would be great. 😊

Anyway, I can do a final check with the last changes with subdomain false.

matifali commented 1 month ago

I left a few comments and suggestions on possible issues with url.