coder / modules

A collection of Terraform Modules to extend Coder templates.
https://registry.coder.com
Apache License 2.0
33 stars 33 forks source link

fix(filebrowser): support custom base_url in case of custom db path #320

Closed yandolfat closed 1 month ago

yandolfat commented 1 month ago

Proposal to fix #309.

matifali commented 1 month ago

Hi @yandolfat, do you plan to come back to this PR? I would be happy to complete this if you are not available. Thanks for the PR.

yandolfat commented 1 month ago

Hi @yandolfat, do you plan to come back to this PR? I would be happy to complete this if you are not available. Thanks for the PR.

Hi, if there is nothing to add, you can complete it, thanks :)

matifali commented 1 month ago

@yandolfat Could you test the updated functionality by setting the source as

module "filebrowser" {
  source     = "git::https://github.com/yandolfat/modules.git//filebrowser?ref=patches/filebrowser"
  agent_id   = coder_agent.example.id
  agent_name = "main"
  subdomain  = false
}
yandolfat commented 1 month ago
"git::https://github.com/yandolfat/modules.git//filebrowser?ref=patches/filebrowser"

Seems to work :)

https://imgur.com/a/YTpEWY5