coder / modules

A collection of Terraform Modules to extend Coder templates.
https://registry.coder.com
Apache License 2.0
33 stars 33 forks source link

feat(jetbrains-gateway): add slug variable #322

Closed matifali closed 1 month ago

matifali commented 1 month ago
matifali commented 1 month ago

@dannykopping Thank you. I will extract the ordering changes to a separate PR.

djarbz commented 1 month ago

@matifali I just saw this on your v1.0.21 release. Just wondering if it might have been better to have the default be the selected IDE? That way it should always be unique by default, I don't see a reason to add the same IDE more than once.

matifali commented 1 month ago

@djarbz The dault should already be the selected IDE> IF you use the module like

module "jetbrains_gateway" {
  source         = "registry.coder.com/modules/jetbrains-gateway/coder"
  version        = ">= 1.0.0"
  agent_id       = coder_agent.dev.id
  agent_name     = "dev"
  folder         = local.repo_dir
  jetbrains_ides = ["GO", "WS"]
  default        = "GO"
  latest         = true
}

Then GoLand will be the selected IDE when creating the workspace.

I did this for a user request to display two buttons on the workspace page, and an easier way to achieve that was to allow the module to be re-used. Unfortunately, that solution did not work because the same coder_parameter name can't be used twice.

djarbz commented 1 month ago

Ahh, I was referring to this default.

variable "slug" { 
   type        = string 
   description = "The slug for the coder_app. Allows resuing the module with the same template." 
   default     = "gateway" 
 }