coder / sail

Deprecated: Instant, pre-configured VS Code development environments.
https://sail.dev
MIT License
629 stars 36 forks source link

Trying to run in WSL #210

Open jefflindholm opened 5 years ago

jefflindholm commented 5 years ago

2019-06-05 10:13:11 ERROR build run failed: failed to run container: failed to create container: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /home/jeffl/.config/Code

The path does exist and the permissions seem fine, any way to get the docker details it is trying to run? There is nothing in the logs.

deansheather commented 5 years ago

Docker's running in Windows right? If that's the case, sail is passing Docker Windows a unix style path instead of a Windows style path for binding your VSCode configuration folder to code-server's configuration folder.

We don't officially support Windows, but this should be pretty easy to fix.

deansheather commented 5 years ago

Looks like getting sail to work in WSL will require a few workarounds. I don't have Windows or WSL myself to test any of these, but from what I can tell you'll need to do the following steps:

  1. Checkout wsl-compatibility (from the above PR) and build it

  2. Add the following to /etc/wsl.conf (create it if it doesn't exist, this will move /mnt/c to /c which Docker can read apparently):

    [automount]
    root = /
  3. Restart WSL and make sure that /c exists and is the same as C:\

  4. Set your $HOME environment variable to somewhere in /c (probably /c/Users/something): export HOME=/c/Users/something

    Sail configuration and globalStorage directories will end up in $HOME/.config/sail. You could persist this variable by replacing sail with a bash script in your path.

  5. Set your $TMPDIR environment variable to somewhere in /c (probably /c/tmp, make sure this exists): export TMPDIR=/c/tmp

  6. Create $HOME/.config/sail/sail.toml with the default configuration and then change the project root to an absolute path within /c

  7. Ensure you don't have a running ssh-agent/X11 server (or do unset SSH_AUTH_SOCK && unset DISPLAY)

  8. Add VSCODE_CONFIG_DIR and VSCODE_EXTENSIONS_DIR environment variables, set to somewhere in /c

I'm not sure if any further steps are needed since I can't test this myself. Try with my PR branch and see if you can get it to work.

deansheather commented 5 years ago

@jefflindholm Could you please try again with the newest release, following the workarounds I listed above and let me know how that goes? It's possible I missed something.

jefflindholm commented 5 years ago

Getting the same error with the bind. Docker for windows should work with volumes etc. It might be that the binds require relative directories to work, all my other docker commands I am using relative paths to mount WSL directories. I will try again when I can get WSL2 installed, where I can share directories across without issue. Thanks for the attempt.

deansheather commented 5 years ago

I'm not too sure how WSL works, but maybe it's translating the pathnames to the Windows version before passing them to docker.

sr229 commented 5 years ago

@deansheather WSL is just translation layer for the Linux syscalls to the NT syscalls, I think we should only support WSL2 since Windows will be using a entire kernel by default.