search

coder / sail

Deprecated: Instant, pre-configured VS Code development environments.
https://sail.dev
MIT License
629 stars 36 forks source link

Install go binaries by default #230

Closed teddy-codes closed 5 years ago

teddy-codes commented 5 years ago

This is an attempt to make vscode-go work upon initial startup on the sail container, but it does not look like this is the proper solution since I had to run go: install/update binaries within code-server...

Any thoughts on this?

cc: @coadler @ammario @deansheather

coadler commented 5 years ago

Would this not work in a hat?

ammario commented 5 years ago

this should be in the install_go_tools script?

teddy-codes commented 5 years ago

But, this does not currently work with vscode-go and I am unsure why. I am hoping to get some help with this.

deansheather commented 5 years ago

Dockerfile.comm sets the GOPATH to /go instead of ~/go (which is referenced in multiple places).

This can probably be fixed if we remove the GOPATH stuff from Dockerfile.comm (we can't create it there since /home/user doesn't exist yet) into Dockerfile.lang. Testing now.

deansheather commented 5 years ago

Fixed it, opening a PR.

deansheather commented 5 years ago

@roberthmiller Could you docker pull codercom/ubuntu-dev-go and recreate your Sail image/containers? vscode-go should work properly out-of-the-box now.