Approved hosts - Githubissues

coder / sail

Deprecated: Instant, pre-configured VS Code development environments.

https://sail.dev

MIT License

629 stars 36 forks source link

Approved hosts #238

Closed deansheather closed 5 years ago

deansheather commented 5 years ago

Closes #237.

TODO:

[x] Add styling to extension config page and popup page
[x] Test security
[x] Is it safe to lowercase hostnames?
[x] Validate the hosts added in the config page
[x] Make errors more visible to user

teddy-codes commented 5 years ago

As per one of the TODOs, it is safe to lowercase all hosts because uppercase and lowercase values would be routed to the same place. Not really sure if that helps at all.

deansheather commented 5 years ago

Screenshot

teddy-codes commented 5 years ago

I like the UI for that.

deansheather commented 5 years ago

Popup doesn't exist anymore, and the extension "browser action" now opens the config page.

deansheather commented 5 years ago

I think this is ready, I've tested that it works on GitHub. I don't think there's any security issues with how it prompts for consent on hosts that aren't already approved (right now the background script injects a confirm dialog into the target tab).

lucacasonato commented 5 years ago

I just wanted to say that the work you did for moving the websocket to the background script I already did in #225, but @kylecarbs still hasn't reviewed it. It's like 2 months old now.