coder / sail

Deprecated: Instant, pre-configured VS Code development environments.
https://sail.dev
MIT License
629 stars 36 forks source link

Unable to install with msys #239

Closed Merith-TK closed 5 years ago

Merith-TK commented 5 years ago

I get this issue while installing, using instructions from https://sail.dev/docs/installation/ build go.coder.com/sail: cannot load go.coder.com/sail/internal/editor: no Go source files

any idea why?

$ go env
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\ShitNuggit\AppData\Local\go-build
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:/Miscellaneous/msys/usr/local/gopath
set GOPROXY=
set GORACE=
set GOROOT=c:\go
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\Miscellaneous\msys\home\ShitNuggit\src\sail\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Miscellaneous\msys\tmp\go-build634270934=/tmp/go-build -gno-record-gcc-switches
Merith-TK commented 5 years ago

And please do ignore my username.

On Wed, Jul 24, 2019, 5:06 PM Merith notifications@github.com wrote:

I get this issue while installing, using instructions from https://sail.dev/docs/installation/ build go.coder.com/sail: cannot load go.coder.com/sail/internal/editor: no Go source files

any idea why?

$ go env set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\ShitNuggit\AppData\Local\go-build set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOOS=windows set GOPATH=C:/Miscellaneous/msys/usr/local/gopath set GOPROXY= set GORACE= set GOROOT=c:\go set GOTMPDIR= set GOTOOLDIR=c:\go\pkg\tool\windows_amd64 set GCCGO=gccgo set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD=C:\Miscellaneous\msys\home\ShitNuggit\src\sail\go.mod set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Miscellaneous\msys\tmp\go-build634270934=/tmp/go-build -gno-record-gcc-switches

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cdr/sail/issues/239?email_source=notifications&email_token=ACPQOXTE4X2U3WYYY27R5GTQBDVAHA5CNFSM4IGVXTF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBLMDBA, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPQOXRQVC23LICQJK6GIILQBDVAHANCNFSM4IGVXTFQ .

deansheather commented 5 years ago
GOHOSTOS=windows

Sail only supports Linux and Darwin. If you look in sail/internal/editor/editor.go you'll notice that it is setup so it only builds on Linux and Darwin.

Please refer to #210 and #151.

teddy-codes commented 5 years ago

What is the reason why it only builds on linux and darwin? Is there a specific thing that is blocking it from being built on windows? beside the derivatives at the top of the file

deansheather commented 5 years ago

Not sure. It's probably because most Linux distros (and Darwin) include vim out of the box. Windows doesn't have vim or any other good editor out of the box.

cc: @ammario

teddy-codes commented 5 years ago

Notepad:tm:

ammario commented 5 years ago

I don't think there's anything preventing it from being built or ran on Windows. Just need to try and see what happens.

Merith-TK commented 5 years ago

I actually modified the parts the make it freak out, and gives me a random syscall error thing, will post outputs once windows finishes updating.

Also, why not use the default EDITOR variable on Linux environments? All Msys is, is pretty much a file system (as loose as that term can be used) compatibility between windows and Linux,

teddy-codes commented 5 years ago

https://github.com/cdr/sail/blob/bcf906366e626d48e9722319c3d50b5d8c48ec02/internal/editor/editor.go#L12

It already uses the EDITOR env var.