search

coder / sail

Deprecated: Instant, pre-configured VS Code development environments.
https://sail.dev
MIT License
629 stars 36 forks source link

Add makefile #241

Closed teddy-codes closed 5 years ago

teddy-codes commented 5 years ago

Created a makefile that should be used when people want to build from source instead of using the custom script provided.

/cc @deansheather

Edit: Resolves #240

teddy-codes commented 5 years ago

Should I do a quick check within the makefile to ensure that the OS is supported?

Also, should I add a GOOS value with the go build command?

deansheather commented 5 years ago

Probably best to leave the GOOS up to the user as it's an env variable. I don't think it's neccessary to restrict what OS is supported.

deansheather commented 5 years ago

Bump

teddy-codes commented 5 years ago

Yea, my bad. I have been away and trying to catch up.

teddy-codes commented 5 years ago

@deansheather should be good to go now