search

coder / sail

Deprecated: Instant, pre-configured VS Code development environments.
https://sail.dev
MIT License
629 stars 36 forks source link

Use code-server v2, download via codesrv-ci.cdr.sh #244

Closed deansheather closed 4 years ago

deansheather commented 4 years ago

Currently set to use 2.1485-vsc1.38.1. Downloaded from https://codesrv-ci.cdr.sh/releases/$release/linux-x86_64/code-server. Using linux-x86_64 shouldn't be a problem (and is what it used before this PR too) as docker on Mac runs in a VM AFAIK.

code-server v2 doesn't support --port 0 yet, and defaults to 8080. @code-asher should be working on resolving this soon. This shouldn't interfere with using this PR unless you run multiple containers at the same time.

This also hardcodes the code-server release identifier into the source, meaning when we release new versions of code-server we need to release a new version of Sail for the benefit of reliability. I think this is a good trade off, considering Sail's mission is to be reliable and reproducible.

deansheather commented 4 years ago

Bumped code-server version to the newest release, 2.1523-vsc1.38.1, which fixes the port 0 problem.

deansheather commented 4 years ago

@cadler Can I have your opinion on baking the code-server version to use into sail? Last paragraph of OP