coder / sail

Deprecated: Instant, pre-configured VS Code development environments.
https://sail.dev
MIT License
629 stars 36 forks source link

FIXES #201 Sail browser extension docker not found error on MacOS #264

Closed dougnukem closed 4 years ago

dougnukem commented 4 years ago

FIXES #201 chrome extension: failed to run docker info

On MacOS when Chrome is launched from Finder (as opposed to from terminal/shell session) the $PATH environment variable does not contain /usr/local/bin which is the common location for docker to be installed.

This PR adds in /usr/local/bin to be included in the PATH env variable on MacOS darwin.

See similar issues with other browser extensions that rely on Go to execute commands on the user's path:

browserpass/browserpass-legacy#13 browserpass/browserpass-legacy#159

dougnukem commented 4 years ago

/cc @deansheather

dougnukem commented 4 years ago

@deansheather accepted PR suggestions