coder / sail

Deprecated: Instant, pre-configured VS Code development environments.
https://sail.dev
MIT License
629 stars 36 forks source link

sail run cdr/sail fails "Unknown option --data-dir" #270

Open chafey opened 4 years ago

chafey commented 4 years ago

OS: Ubuntu 18.04 LTS desktop (running in virtual machine) Docker: 19.03.8 Git: 2.17.1

Here is the end of the console output:

chafey@linuxmint:~$ sail run cdr/sail
2020-04-04 15:22:03 INFO    running docker build --network=host -t cdr_sail -f /home/chafey/Projects/cdr/sail/.sail/Dockerfile /home/chafey/Projects/cdr/sail --label com.coder.sail.base_image=cdr_sail
Sending build context to Docker daemon  9.506MB
Step 1/7 : FROM codercom/ubuntu-dev-go:latest
 ---> 1dae51fcd27f
Step 2/7 : SHELL ["/bin/bash", "-c"]
 ---> Using cache
 ---> 0f2735aed597
Step 3/7 : RUN sudo apt-get update &&     sudo apt-get install -y htop
 ---> Using cache
 ---> 787baab67bde
Step 4/7 : RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash &&   . ~/.nvm/nvm.sh   && nvm install node
 ---> Using cache
 ---> 727021ac2bb8
Step 5/7 : LABEL project_root "~/go/src/go.coder.com"
 ---> Using cache
 ---> 49715d1d7243
Step 6/7 : RUN wget -O /tmp/hugo.deb https://github.com/gohugoio/hugo/releases/download/v0.55.4/hugo_extended_0.55.4_Linux-64bit.deb &&   sudo dpkg -i /tmp/hugo.deb &&   rm -f /tmp/hugo.deb
 ---> Using cache
 ---> f72071ec13e9
Step 7/7 : LABEL com.coder.sail.base_image=cdr_sail
 ---> Using cache
 ---> 9cf7d7d1fd51
Successfully built 9cf7d7d1fd51
Successfully tagged cdr_sail:latest
2020-04-04 15:22:04 INFO    using repo image cdr_sail
2020-04-04 15:22:04 INFO    writing sail proxy logs to /tmp/sailproxy_cdr_sail142932399
2020-04-04 15:22:05 ERROR   failed to wait for project to be online: container cdr_sail not running
+ cd /home/user/go/src/go.coder.com/sail
+ sudo chown user:user /home/user/.vscode
+ code-server --host localhost --port 0 --data-dir /home/user/.config/Code --extensions-dir /home/user/.vscode/host-extensions --extra-extensions-dir /home/user/.vscode/extensions --allow-http --no-auth
+ tee /tmp/code-server.log
Unknown option --data-dir
2020-04-04 15:22:05 ERROR   build run failed: container cdr_sail not running
chafey commented 4 years ago

Building and running the master version of sail did not resolve this issue, but it did produce a new error "Unknown option --allow-http"

chafey@linuxmint:~/src/sail$ ./sail run cdr/sail
2020-04-05 14:34:20 INFO        running docker build --network=host -t cdr_sail -f /home/chafey/Projects/cdr/sail/.sail/Dockerfile /home/chafey/Projects/cdr/sail --label com.coder.sail.base_image=cdr_sail
Sending build context to Docker daemon  9.506MB
Step 1/7 : FROM codercom/ubuntu-dev-go:latest
 ---> 1dae51fcd27f
Step 2/7 : SHELL ["/bin/bash", "-c"]
 ---> Using cache
 ---> 0f2735aed597
Step 3/7 : RUN sudo apt-get update &&     sudo apt-get install -y htop
 ---> Using cache
 ---> 787baab67bde
Step 4/7 : RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.34.0/install.sh | bash &&   . ~/.nvm/nvm.sh   && nvm install node
 ---> Using cache
 ---> 727021ac2bb8
Step 5/7 : LABEL project_root "~/go/src/go.coder.com"
 ---> Using cache
 ---> 49715d1d7243
Step 6/7 : RUN wget -O /tmp/hugo.deb https://github.com/gohugoio/hugo/releases/download/v0.55.4/hugo_extended_0.55.4_Linux-64bit.deb &&   sudo dpkg -i /tmp/hugo.deb &&   rm -f /tmp/hugo.deb
 ---> Using cache
 ---> f72071ec13e9
Step 7/7 : LABEL com.coder.sail.base_image=cdr_sail
 ---> Using cache
 ---> 9cf7d7d1fd51
Successfully built 9cf7d7d1fd51
Successfully tagged cdr_sail:latest
2020-04-05 14:34:21 INFO        using repo image cdr_sail
2020-04-05 14:34:21 INFO        writing sail proxy logs to /tmp/sailproxy_cdr_sail659976749
2020-04-05 14:34:22 ERROR       failed to wait for project to be online: container cdr_sail not running
+ cd /home/user/go/src/go.coder.com/sail
+ sudo chown user:user /home/user/.vscode
+ tee /tmp/code-server.log
+ /usr/bin/code-server --host localhost --port 0 --user-data-dir /home/user/.config/Code --extensions-dir /home/user/.vscode/host-extensions --extra-extensions-dir /home/user/.vscode/extensions --auth=none --allow-http
Unknown option --allow-http
2020-04-05 14:34:22 ERROR       build run failed: container cdr_sail not running
chafey commented 4 years ago

Digging into this more and am discovering some really strange things. Sail depends on the docker image codercom/ubuntu-dev-go:latest which was updated on 3/18/2020 with digest 36afe0c005fc. This image includes version 3.0.1 of code-server which was released 3/27/202 which is a whole 9 days AFTER the docker image was created. How can a docker image include a piece of software that hasn't been released yet? Perhaps I am misunderstanding things, but this project may be compromised - best to steer clear until the maintainers fix things and explain what happened

duncanbeevers commented 4 years ago

It looks like this should be resolved by https://github.com/cdr/sail/issues/268