Wrong version output - Githubissues

coder / sshcode

Run VS Code on any server over SSH.

MIT License

5.74k stars 216 forks source link

Wrong version output #106

Closed maxfi closed 5 years ago

maxfi commented 5 years ago

Using https://github.com/cdr/sshcode/releases/download/v0.7.0/sshcode-darwin-amd64.tar:

~ ./sshcode --version
v0.6.0-10-gdd4825b

This is the wrong version.

badaz commented 5 years ago

I noticed that too, I also noticed that if you install sshcode with go you seem to get the latest version since it installs the server in a user local dir instead of /tmp. However sshcode --version now returns an empty string

teddy-codes commented 5 years ago

@ammario Can you run ci/build.sh again and update the release?

ammario commented 5 years ago

@badaz that is because we use build flags to specify the version. There's not a clean solution other than requiring everyone to go install/go build with that flag.

ammario commented 5 years ago

Tagged version v0.8.0 and retroactively fixed v0.7.0