search

coder / sshcode

Run VS Code on any server over SSH.
MIT License
5.74k stars 216 forks source link

Adding git bash support, closes #94 #124

Closed eargollo closed 5 years ago

eargollo commented 5 years ago
eargollo commented 5 years ago

@deansheather, I fixed all the issues but the enable connection error you mentioned. I could not reproduce it. Can you give me some more info on it?

Merith-TK commented 5 years ago

My build is finnished for now. I am waiting for @eargollo to do his thing.

Merith-TK commented 5 years ago

@eargollo Can you email me with the email on my profile?

eargollo commented 5 years ago

@Merith-TK, sorry for the long delay. I was on vacations.

What is the status? How can I be of help?

Merith-TK commented 5 years ago

No worries! I got the issues with your code fixed. Look at the new PR for the current issues

On Thu, Aug 15, 2019, 10:24 AM Eduardo Argollo notifications@github.com wrote:

@Merith-TK https://github.com/Merith-TK, sorry for the long delay. I was on vacations.

What is the status? How can I be of help?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cdr/sshcode/pull/124?email_source=notifications&email_token=ACPQOXTUEEGJEZJX534YXJDQEWGLJA5CNFSM4H67SFOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4MOEXQ#issuecomment-521724510, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPQOXRTUOGQFUDOPK7LBLLQEWGLJANCNFSM4H67SFOA .

deansheather commented 5 years ago

Should this PR be closed in favor of the other one? @Merith-TK @eargollo

Merith-TK commented 5 years ago

I think so, but according to my last communication with @eargollo , he is mostlikely swamped by work.

Currently my fork is working with oen caviat the i cant explain... I sent it to you over discord @deansheather