search

coder / sshcode

Run VS Code on any server over SSH.
MIT License
5.74k stars 215 forks source link

Add support for google-chrome-beta to startup. #161

Closed IngCr3at1on closed 4 years ago

IngCr3at1on commented 4 years ago

This allows users running google-chrome-beta to still open the app inside electron instead of inside a browser tab.

Merith-TK commented 4 years ago

what if someone wants to run the program under a different chrome? and it opens beta?

IngCr3at1on commented 4 years ago

what if someone wants to run the program under a different chrome? and it opens beta?

Hmm.. it didn't occur to me that anyone would bother having more than one version installed (yes I realize now that's a bad assumption) but the requirement that someone install a version of chrome other than the beta also seems silly to me... Perhaps a flag (-allow-beta)? lol

Merith-TK commented 4 years ago

Yeah the flag would make more sense, personally I am testing how feasible it would be to use the electron binary instead of chrome. Because some people do have electron installed

On Fri, Dec 27, 2019, 1:40 PM Nathan Bass notifications@github.com wrote:

what if someone wants to run the program under a different chrome? and it opens beta?

Hmm.. it didn't occur to me that anyone would bother having more than one version installed (yes I realize now that's a bad assumption) but the requirement that someone install a version of chrome other than the beta also seems silly to me... Perhaps a flag (-allow-beta)? lol

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cdr/sshcode/pull/161?email_source=notifications&email_token=ACPQOXW6MZESNXJ2GWDXNGDQ2ZY5PA5CNFSM4KACJ3C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXZTPI#issuecomment-569350589, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQOXV2Y6C4LV35V4Z5BETQ2ZY5PANCNFSM4KACJ3CQ .

IngCr3at1on commented 4 years ago

Yeah the flag would make more sense, personally I am testing how feasible it would be to use the electron binary instead of chrome. Because some people do have electron installed … On Fri, Dec 27, 2019, 1:40 PM Nathan Bass @.***> wrote: what if someone wants to run the program under a different chrome? and it opens beta? Hmm.. it didn't occur to me that anyone would bother having more than one version installed (yes I realize now that's a bad assumption) but the requirement that someone install a version of chrome other than the beta also seems silly to me... Perhaps a flag (-allow-beta)? lol — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#161?email_source=notifications&email_token=ACPQOXW6MZESNXJ2GWDXNGDQ2ZY5PA5CNFSM4KACJ3C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHXZTPI#issuecomment-569350589>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPQOXV2Y6C4LV35V4Z5BETQ2ZY5PANCNFSM4KACJ3CQ .

Though now that I think about it... Switch statements happen in order so it should only hit the beta version if it fails to find the others anyway... Would need testing but in theory the way I wrote it should actually launch it outside of beta unless beta is all that's there

IngCr3at1on commented 4 years ago

Confirmed... Installed chrome (non-beta) and reran it and it opens within Chrome (not Chrome-beta). IMHO this PR is correct as is; even without a flag as the beta version is a fallback that will only occur if no other version of google-chrome is found.

deansheather commented 4 years ago

I'm going to close this PR as I don't think it's necessary to support every browser out there. We should support stable versions of Chrome on Windows, Mac and Linux (because it has the borderless app window flags), and if Chrome isn't installed code-server will open in the default browser.

Merith-TK commented 4 years ago

we should support the new msedge-chromium as more people may be moving away from chrome because edge just works and is rather quick, and has a better UI on windows and MacOS,

i can easily make a windows version of this. using msedge_proxy.exe as it funcitons better than just msedge.exe