search

coder / sshcode

Run VS Code on any server over SSH.
MIT License
5.74k stars 216 forks source link

Add electron support #162

Closed Merith-TK closed 4 years ago

Merith-TK commented 4 years ago

This adds the electron binary into the commandExists check switch in sshcode.go, and if electron is found, use it.

This idea works because that means that certain extenstions such as adblockers, (or in braves case, the built in blocker which is enabled even when extenstions are not)

GrimTheReaper commented 4 years ago

It might be a good idea to add a flag to specify a browser or application to be used. On another note, I'm also writing the ssh portion in JS, and shoving it into an Electron stand alone app.

deansheather commented 4 years ago

Closing this for the same reason as #161. We should only support Chrome stable, and if it isn't installed we should fallback to the default system browser. Supporting electron is a very niche use case in any case, as electron developers most likely already have Chrome on their machine.

Ad blockers can be excluded from running on certain domains, so if an ad blocker is interfering with code-server they can fix it in a few clicks.