search

coder / sshcode

Run VS Code on any server over SSH.
MIT License
5.74k stars 215 forks source link

fix #167 use latest version of code-server #182

Closed gyzerok closed 4 years ago

gyzerok commented 4 years ago

Hello!

This PR fixes https://github.com/cdr/sshcode/issues/167

There was a bit of a jungle with https://github.com/cdr/sshcode/pull/178 and https://github.com/cdr/sshcode/pull/181, so let me explain what happened.

Big thanks to @Merith-TK I realized, that the different PR order would make more sense. However we misunderstood each other a bit with the PR openings. Anyway - everything is clear now, so I am making the PRs in the right order. My apologies for the PR jungling :)

gyzerok commented 4 years ago

@nhooyr would you mind taking a look?

Merith-TK commented 4 years ago

there is a button on the side that requests a reveiw. or down below here, i forgot

gyzerok commented 4 years ago

I do not see any button. There is a section on the right side, but I can't use it. Maybe you can because you have collaborator status?

nhooyr commented 4 years ago

@gyzerok Thanks for contributing, sorry for the late response.

I'll take a look at this soon.

gyzerok commented 4 years ago

It seems that after 3.3.0 update it got broken for my environment at least. So I invite you to help me figure out the most proper solution before we merge it. I am willing to incorporate any suggestions to make it the best experience for others.

Zero idea what it's about, but maybe you can help - Error: /lib/x86_64-linux-gnu/libc.so.6: versionGLIBC_2.28' not found`.

nhooyr commented 4 years ago

See https://github.com/cdr/code-server/issues/1656

nhooyr commented 4 years ago

@gyzerok Can you hold off on further work here?

We're discussing deprecating sshcode in favour of a bash script that we maintain as part of code-server with most of the same functionality. I'll keep you posted on it. Don't want you to waste time on something that might not be merged.

Merith-TK commented 4 years ago

@nhooyr I would recommend making it an shell script instead of a bash script. As not all remote systems use bash, nor do all clients have bash installed.

nhooyr commented 4 years ago

@Merith-TK Yup, sorry I meant a shell script.

gyzerok commented 4 years ago

@nhooyr right now no further work is happening. I just have added ability to pass additional flags to the code-server and were planning to make it a separate PR.

Thanks for notifying me. Will be awaiting for you decision :)

nhooyr commented 4 years ago

See https://github.com/cdr/sshcode/issues/185