Revert behavior using DISPLAY to open app window

coder / sshcode

Run VS Code on any server over SSH.

MIT License

5.74k stars 216 forks source link

Closed sreya closed 5 years ago

sreya commented 5 years ago

Previously the DISPLAY environment variable was consulted when determining whether to open a browser app window. However, it appears the environment variable isn't set in some supported environments, so the behavior has been updating to always open a window.

nhooyr commented 5 years ago

@sreya92 this should only be the case on macOS. on linux, we still want to use $DISPLAY.

nhooyr commented 5 years ago

Actually I guess not, its best we just turn the error into a warning.