coder / terraform-provider-coder

https://coder.com
Mozilla Public License 2.0
31 stars 20 forks source link

fix: update to terraform-plugin-sdk v2.34.0 #290

Closed spikecurtis closed 1 month ago

spikecurtis commented 1 month ago

Speculative fix in relation to https://github.com/coder/coder/issues/14726

There have been several issues fixed in the plugin-sdk and its dependencies about go routines and the RPC protocol. Since our coder plugin is itself very, very simple in design (it generally just reads data from environment variables for data sources, and just does validation on resources), it's hard to imagine a hang in our provider schema code (not impossible tho). The error reports we've seen all show the Coder provider as the one that is involved in text file busy, so it seems likely that it's something unique about the coder/coder provider.

hashicorp/kubernetes is used by both customers who reported the text file busy error, and it is on SDK version 2.29+ and we were back on 2.20 before this PR.

spikecurtis commented 1 month ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

spikecurtis commented 1 month ago

Merge activity

matifali commented 1 month ago

@spikecurtis we can patch the 1.0 after cherry picking this change into release/1.0 branch.