coder / websocket

Minimal and idiomatic WebSocket library for Go
ISC License
3.91k stars 296 forks source link

Read method #488

Closed kehiy closed 3 weeks ago

kehiy commented 1 month ago

I think a method to read pure data is required. sometimes developer needs to read different stuff not only JSON. or maybe they want to use other/custom parsers.

mafredri commented 1 month ago

Hi @kehiy, could you give an example of what you tried and how it didn't work for you? There already exists a Read-method.

kehiy commented 1 month ago

Hi @mafredri, Here is an example of what I want using x/net/websocket:

https://github.com/kehiy/immortal/blob/feature/ws/server/server.go

I read raw stringified JSON in []byte and parse it using my preferred parser. as you mentioned on readme the wensocket of Golang is no longer maintained and it's not performant. So I'm searching for a way to replace the package with coder/websocket.

This is my first issue.

Another issue I found is that I think the assembly stuff in still under develop which is one of the performance reasons, so, when do you think it will be done? I can help on the process as well since a good Golang websocket is really needed.

kehiy commented 1 month ago

I checked existing Read method, let me check if it can do the same thing. Thanks a lot.