coder3101 / protols

Language Server for protocol buffers
MIT License
46 stars 2 forks source link

Jump to definition - other files #18

Closed Solverj closed 2 months ago

Solverj commented 2 months ago

I have a message defined where I use buf to manage dependencies like this:

syntax = "proto3";

package secret.v1;

option go_package = "github.com/X/Y/gen/go/secret/v1;secretv1";

import "meta/v1/meta.proto";
import "google/protobuf/timestamp.proto";
import "buf/validate/validate.proto";

message Secret {
    meta.v1.TypeMeta type = 1;
    meta.v1.ObjectMeta metadata = 2;
        SecretSpec spec = 3;
}

message SecretSpec {
        bytes data = 1[(buf.validate.field).bytes = {min_len: 1}, (buf.validate.field).required = true];
}

I'd like to be able to hover over meta.v1.TypeMeta goto definition and jump to correct file.

coder3101 commented 2 months ago

As of now we only support single file mode operations. In future we will allow jumping, hover across files.

Solverj commented 2 months ago

Amazing job! Holy crap how fast you were with implementing this. I've been watching you work all weekend comit by comit waiting exitidly for this release! Thank you so much!