search

coder5876 / simple-multisig

Simple multisig for Ethereum using detached signatures
MIT License
247 stars 108 forks source link

License of the contract #10

Closed ScJa closed 6 years ago

ScJa commented 7 years ago

Hi,

I would like to use an adaption of your contract for a research project, would you be ok with licensing it (e.g. MIT license)?

Thanks, Jakob

coder5876 commented 7 years ago

Hi Jakob! Sure, I can MIT license it, no problem! May I ask what the research project is?

VoR0220 commented 7 years ago

I too am looking to slightly modify this so that instead of sending funds it's assigning roles. It's very well designed.

coder5876 commented 7 years ago

@VoR0220 note that it can currently send any possible Ethereum transaction except creating contracts (not just sending funds), so you may be able to do what you want with the contract as-is.

VoR0220 commented 7 years ago

@christianlundkvist That's the thing ;) I want to be able to create contracts with this

coder5876 commented 7 years ago

@VoR0220 Ah got it!

ScJa commented 6 years ago

@christianlundkvist My master thesis covers how to safely hold cryptocurrency funds as a business. I will also propose possible implementations. I would extend your smart contract so it would be able to support different owner-weights (e.g. the CEO would count as two signatures).

VoR0220 commented 6 years ago

also the ability to just switch a user is nice. I'm assuming that someone is going to lose a private key somewhere and they should be able to replace it somehow.

VoR0220 commented 6 years ago

@ScJa That's a damn good suggestion, but again, the title is "simple-multisig"...I think it's meant to be extended.

coder5876 commented 6 years ago

@ScJa @VoR0220 Note that the goal was to make the contract as simple as possible which is why it doesn’t have the advanced features of replacing owners, added weights etc. Note that having the CEO count as two signatures could probably be done client side by having the CEO use two keys (potentially hidden by a UI).

In any case I added an MIT licence in this commit: https://github.com/christianlundkvist/simple-multisig/commit/15a8095818008b0bf3eb901e488d0c5b488513d4

ScJa commented 6 years ago

Thanks Christian, I wasn't suggesting for you to add this feature, I'm aware it is a "luxury". I was only trying to give you information about what I plan to adapt.

ScJa commented 6 years ago

Hi Chris, A follow-up for what I used your code for: Just now I published ERCFund, an open-ended investment fund software built entirely on the blockchain. With it you can create actively managed portfolios of ERC20-tokens and gather continous investments by minting new shares on demand. I got a large part of my ideas for the multi-sig part from your repo and have credited you :) If you're interested I invite you to check it out! Happy about any feedback. https://github.com/ScJa/ercfund