search

coder5876 / simple-multisig

Simple multisig for Ethereum using detached signatures
MIT License
247 stars 108 forks source link

Add a bit of documentation to the constructor #23

Closed ripper234 closed 6 years ago

ripper234 commented 6 years ago

It's not clear what this piece of code does. 

address lastAdd = address(0); 
for (uint i = 0; i < owners_.length; i++) {
  require(owners_[i] > lastAdd);
  isOwner[owners_[i]] = true;
  lastAdd = owners_[i];
}

Why do you require(owners_[i] > lastAdd);? Are you checking that the address array is sorted (this should be document above the constructor)? Why? Is it to prevent duplicate addresses?

ripper234 commented 6 years ago

Addressed in this pull request