search

coderGtm / yantra-app-launcher

A minimal CLI based Android app Launcher
https://play.google.com/store/apps/details?id=com.coderGtm.yantra
Other
51 stars 19 forks source link

Saving of custom themes #169

Closed Anready closed 2 months ago

Anready commented 2 months ago

With export/import

coderGtm commented 2 months ago

Can you explain the flow of the suggested changes? Like, what and how?

coderGtm commented 2 months ago

Also, please ensure this does not have conflicts or crashes and works properly after merging #168 as it targeted the same area: themes.

Anready commented 2 months ago

Can you explain the flow of the suggested changes? Like, what and how?

So, in sharedPreference we just save new custom theme: name: theme[NameWhichUserWrote] value: i just get value from current custom theme ( i dont remember which name of it in sharedpreference), and add to list with custom theme (as list in sharedpreference), this value will use to add it in suggestion list. Also export of theme by typing: theme [name_of_custom_theme] -e. Import: backup -t. Saving of theme: theme -s [theme_name]. Deleting: theme -d [theme_name].

Anready commented 2 months ago

Also, please ensure this does not have conflicts or crashes and works properly after merging #168 as it targeted the same area: themes.

As much as i tested on 2 devices, all was okay, you can set default themes and saved themes, also this about imported themes

KevinFerryJr commented 2 months ago

Also, please ensure this does not have conflicts or crashes and works properly after merging #168 as it targeted the same area: themes.

I looked over this pull earlier and only saw one potential conflict in the "command.kt" file where only 8 colors were defined in the custom theme instead of the 9 needed after the addition of #168

Anready commented 2 months ago

Also, please ensure this does not have conflicts or crashes and works properly after merging #168 as it targeted the same area: themes.

I looked over this pull earlier and only saw one potential conflict in the "command.kt" file where only 8 colors were defined in the custom theme instead of the 9 needed after the addition of #168

say why? because someone first opened the pr with editing files include theme files.... okay...