Closed SebKrantz closed 1 year ago
PS: R CMD Check still fails because of undocumented arguments:
Undocumented arguments in documentation object 'read_econdata' ‘agencyid’ ‘provideragencyid’
Undocumented arguments in documentation object 'read_release' ‘agencyid’ ‘provideragencyid’
Undocumented arguments in documentation object 'write_econdata' ‘agencyid’ ‘provideragencyid’
Undocumented arguments in documentation object 'write_release' ‘agencyid’ ‘provideragencyid’
Functions with \usage entries need to have the appropriate \alias entries, and all their arguments documented. The \usage entries must correspond to syntactically valid R code. See chapter ‘Writing R documentation files’ in the ‘Writing R Extensions’ manual.
For multiple versions of the same dataset, e.g.
read_econdata(id = "CPI_ANL_SERIES", tidy = TRUE)
gets v2.0, v2.1 and v2.2 of the CPI,econdata_wide()
andecondata_long()
(workhorses ofecondata_tidy()
) were designed to call themselves, i.e. they are recursive functions. Your prettymeta coding did not respect this i.e. it only worked for a single version of a dataset. I have here adjusted the code a bit to allow getting multiple versions of the same dataset with pretty metadata. Your coding also broke some of my examples, which I fixed here. Finally, I implemented the metadata matching for loops in a slightly more efficient way (indexing data.frame's in a loop is not ideal, plain lists are much more efficient).