coderaanalytics / econdatar

R package for uploading and downloading data to/from www.econdata.co.za
MIT License
6 stars 2 forks source link

PPI metadata mismatch #34

Closed WihanZA closed 3 months ago

WihanZA commented 3 months ago

Hi Codera Team I was trying out some data fetching with the econdatar package and came across some metadata mismatches for the SARB's PPI data. Specifically, series names and labels do not seem aligned. The same is true for the data tables on econdata.co.za. Wasn't sure where to raise the issue, so I came here. Screenshot 2024-05-24 082052 Keep up the good and useful work!

aidanhorn commented 3 months ago

Thank you very much @WihanZA for pointing this out 😊. @byrongibby, the CL_PPI codelist version for MNEMONIC is still on 1.0.0 in the data structure, whereas the latest 1.1.0 has PPI028 = "Petrol".

I will update the data structure, and also create an Issue internally for us to review if this problem exists for any other dataflows.

aidanhorn commented 3 months ago

I've pushed a fix to a private repo. I'm just waiting for approval before running it.

byrongibby commented 3 months ago

Thanks, please do go ahead.

aidanhorn commented 3 months ago

The data structure has been corrected now. Please refresh the website before checking.