search

coderabbi / phpumoji

PHPUnit Emoji Result Printer
MIT License
74 stars 4 forks source link

PHP 7.1 issue #13

Open OwenMelbz opened 6 years ago

OwenMelbz commented 6 years ago

Hey,

We think there might be a slight php 7.1/7.2 compatibility issue with phpunit 7.0.3 (excuse me if you dont expect it to work with this)

owen_batman____sites_alshirawi__zsh__and_slack_-_selesti

The error we actually get when running phpunit is

owen_batman____sites_alshirawi__zsh__and_slack_-_selesti

Is this something you believe can be fixed?

JeroenDeDauw commented 6 years ago

Should be fixable. See these changes that where made to the NyanCat printer:

https://github.com/JeroenDeDauw/nyancat-phpunit-resultprinter/commit/7b9c6a5aefd6fe5103c877ec480a77c7d366d47a https://github.com/JeroenDeDauw/nyancat-phpunit-resultprinter/commit/9854f48170c0e82b8ecd2ed4298f6029c405fd92