search

coderaiser / minify

Minifier of js, css, html and img
https://coderaiser.github.io/minify
MIT License
225 stars 29 forks source link

feature(overwriteSource): add flag to overwrite source files #82

Closed code-forger closed 1 year ago

code-forger commented 2 years ago

Addresses #61

I will write unit tests for this PR once the approach I have used is approved. Let me know if you have any thoughts @coderaiser or if you are happy enough for me to write some tests

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 91f5c2be4385033d5b59ec4ebe554638e206654b on code-forger:feature/overwrite-source into dd4655fb18585c55bf3c9f8502ffa437cac20c90 on coderaiser:master.

coderaiser commented 2 years ago

Would be amazing if you use yargs-parser for this purpose and move all logic to lib/cli.js and add tests with one assertion per test in file lib/cli.spec.js, and it can be ESM, would be awesome if it will :)

code-forger commented 2 years ago

Would be amazing if you use yargs-parser for this purpose and move all logic to lib/cli.js and add tests with one assertion per test in file lib/cli.spec.js, and it can be ESM, would be awesome if it will :)

Done!

coderaiser commented 1 year ago

Any progress on this?

coderaiser commented 1 year ago

Closed due to a long time of inactivity 🏝