coderanger / dco

A command line tool to help manage projects using the Developer Certificate of Origin contributor workflow.

Apache License 2.0

17 stars 1 forks source link

Unable to re-sign old commits #2

Open damacus opened 6 years ago

damacus commented 6 years ago

Error

Run: dco sign

`command': git '--git-dir=/Users/dmw/repos/cookbooks/sous-chefs/php/.git' '--work-tree=/Users/dmw/repos/cookbooks/sous-chefs/php' ls-files '--stage' ''  2>&1:fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths (Git::GitExecuteError)

Environment ChefDK

chef --version

Chef Development Kit Version: 2.4.22
chef-client version: 13.6.4
delivery version: master (73ebb72a6c42b3d2ff5370c476be800fee7e5427)
berks version: 6.3.1
kitchen version: 1.19.2
inspec version: 1.48.0

dco-1.0.1

coderanger commented 6 years ago

Which folder were you in when you ran the command?

coderanger commented 6 years ago

and also which version of git is installed :)

damacus commented 6 years ago

Hey, In folder: /Users/dmw/repos/cookbooks/sous-chefs/php/

git version 2.16.1

I ran it from another Mac and it worked. I "believe" they're setup the same, with the same weird direnv setup and their PATHS are definitely the same. Both using the same version of dco, from the same location.

I'll check the git version on the other mac tomorrow morning.

Thanks

damacus commented 6 years ago

Git version on the machine that works: 2.14.3 (Aple Git-98)

damacus commented 6 years ago

So yes, it's that, the newer version of git seems to break it. Reverting to 2.14.3 allows sign off.