coderazzi / aws_codeartifact_maven

Support to update AWS CodeArtifact credentials on maven IDEA projects.
MIT License
6 stars 6 forks source link

Enhancement: add --no-verify-ssl arge into cli command #13

Closed Happy-ArthurYang closed 10 months ago

Happy-ArthurYang commented 10 months ago

Since the fireware setting in my office/vpn I must use --no-verify-ssl to call aws cli, so does it possible to add this option into the plug?

coderazzi commented 10 months ago

Hi,

A quick solution would be creating a aws-wrapper script, that calls the original AWS script and adds that specific option.

Then you could set the plugin to invoke this wrapper script.

Would that work for you?

Best, Lu

On Sat, Oct 14, 2023, 02:49 ArthurYang @.***> wrote:

Since the fireware setting in my office/vpn I must use --no-verify-ssl to call aws cli, so does it possible to add this option into the plug?

— Reply to this email directly, view it on GitHub https://github.com/coderazzi/aws_codeartifact_maven/issues/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH54IIF4N4VCIXBXQRXTLTX7HOSVAVCNFSM6AAAAAA573PEH2VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DEOBSGYZTENY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Happy-ArthurYang commented 10 months ago

Then how can I set the plugin to invoke the wrapper script? I did not find the place to set it

coderazzi commented 10 months ago

Hi, in the plugin, the last textbox allows you to enter a different PATH location for the AWS script, just point this location to your script and you should be golden, Best, Lu.

On Sat, Oct 14, 2023 at 8:40 AM ArthurYang @.***> wrote:

Then how can I set the plugin to invoke the wrapper script? I did not find the place to set it

— Reply to this email directly, view it on GitHub https://github.com/coderazzi/aws_codeartifact_maven/issues/13#issuecomment-1762666685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH54IKIDTIJ3VBI52C5WMTX7IXW5AVCNFSM6AAAAAA573PEH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRSGY3DMNRYGU . You are receiving this because you commented.Message ID: @.***>

Happy-ArthurYang commented 10 months ago

And the next question is how to ref in input value from the plugin UI. e.g. the Domain, Domain Owner, profile name and Region, if use env, what is the env name should I use? image


coderazzi commented 10 months ago

Hi, I am not sure if I fully understand your question:

When you invoke the AWS script, you only need the domain and domain owner, it will invoked as follows:

aws codeartifact get-authorization-token --domain YOUR-DOMAIN --domain-owner AS_SPECIFIED --query authorizationToken --output text

And this returns the authorization token provided by AWS.

So, your wrapper script should just do something like (in Linux):

aws --no-verify-ssl $*

or, for windows

aws --no-verify-ssl %*

A limitation of this solution is that the AWS cli path defined in the plugin is fixed for all profiles, so if you need to add --no-verify-ssl only for some profiles, you need to make a more complex script, looking for the --domain parameter.

Does this answer your question?

L.

On Sun, Oct 15, 2023 at 3:12 AM ArthurYang @.***> wrote:

And the next question is how to ref in input value from the plugin UI. e.g. the Domain, Domain Owner, profile name and Region, if use env, what is the env name should I use? [image: image] https://user-images.githubusercontent.com/113080404/275295510-4320b320-158a-4179-b98e-ee7515f61d42.png

— Reply to this email directly, view it on GitHub https://github.com/coderazzi/aws_codeartifact_maven/issues/13#issuecomment-1763225551, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH54INODGOIV6QED6UPGA3X7MZ6BAVCNFSM6AAAAAA573PEH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGIZDKNJVGE . You are receiving this because you commented.Message ID: @.***>

Happy-ArthurYang commented 10 months ago

This solution works for me. thank you.