FEATURE: similar items - Githubissues

coderbunker / inventory-server

QR-based CMS for the inventory at coderbunker

https://url.coderbunker.com/search

6 stars 3 forks source link

FEATURE: similar items #17

Open lenzai opened 7 years ago

lenzai commented 7 years ago

bugs and UX flaws , require in-depth redesign of this feature:

displaying broken link to items with no ID.
except for a few specific items, such as printers, picture are not helpful to identify the similar item.
we need to consider item model and location as key discrimination factor for the user.

Let's talk here.

mattermoran commented 7 years ago

What do you mean by items with no ID? If ID is not in the spreadsheet?

mattermoran commented 7 years ago

For images, we could use google images to find the right image for each item

Spazcool commented 7 years ago

@mattermoran that's correct, over half of the items in the spreadsheet do not have UUID. So the link defaults to the root url (ie your react page with the camera on it)

mattermoran commented 7 years ago

Well then solution I have here should work just fine: https://github.com/coderbunker/inventory-server/issues/14

mattermoran commented 7 years ago

Because it would compare the uuid to the ones we already store and then decide to show the item page or display broken link

mattermoran commented 7 years ago

Doug right, this issue, https://github.com/coderbunker/inventory-server/issues/16 and https://github.com/coderbunker/inventory-server/issues/14 basically the same

lenzai commented 7 years ago

@mattermoran

images finding missing images is one step (cf. project board cards, feel free to add comments there or convert it to an issue.) But the real challenge here is that even with images, the Similar items feature would not really be usable.
broken link

16 is the issue.

14 is a confusing discussion. I am still not sure what "broken ID" means besides missing ID.

@Spazcool let's make the redirect to camera page a separate issue.