search

coderbunker / inventory-server

QR-based CMS for the inventory at coderbunker
https://url.coderbunker.com/search
6 stars 3 forks source link

ADD: robots.txt to favicon app.get #40

Closed Spazcool closed 6 years ago

Spazcool commented 6 years ago

This seems to simple a change to be right for issue #35 Is this correct?

lenzai commented 6 years ago

Well, it seems this code is returning status 503 rather than 204. Something was already broken in that favicon code before you even started touching it. @Spazcool

Spazcool commented 6 years ago

@lenzai I'm still uncertain on how to approach this and how it should behave. However, I did find one comment that suggested the status function we were using was for an older version of express.

I've changed to and committed the new syntax, locally the page no longer hangs and remains on whatever page the user had been on and I'm seeing no errors in the console.

lenzai commented 6 years ago

Check the http response status in browser network log or curl then we are done.

On Nov 28, 2017 11:54 AM, "Doug Wright" notifications@github.com wrote:

@lenzai https://github.com/lenzai I'm still uncertain on how to approach this and how it should behave. However, I did find one comment https://stackoverflow.com/questions/35408729/express-js-prevent-get-favicon-ico that suggested the status function we were using was for an older version of express.

I've changed to and committed the new syntax, locally the page no longer hangs and remains on whatever page the user had been on and I'm seeing no errors in the console.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coderbunker/inventory-server/pull/40#issuecomment-347406234, or mute the thread https://github.com/notifications/unsubscribe-auth/ACSBx4XhOckB8gGpau28kJqX75cfwzOPks5s64QKgaJpZM4QrAWz .

Spazcool commented 6 years ago

Both favicon.ico and robots.txt return 204. Any others I need to add?

204response