search

coderbunker / inventory

0 stars 1 forks source link

Changes to inventory #4

Closed mattermoran closed 7 years ago

mattermoran commented 7 years ago

Added inventory app Fixed generaete.sh Replaced qr codes

rngadam commented 7 years ago

I'm going to move this to its own repo

rngadam commented 7 years ago

Is this the latest version? I remember seeing your version with the Coderbunker logo, but now it's the default React logo:

screen shot 2017-08-24 at 9 25 04 am

rngadam commented 7 years ago

Warnings after npm start:

Compiled with warnings.

./src/components/search_bar.js
  Line 39:  'matchedItem' is assigned a value but never used  no-unused-vars
  Line 39:  Expected to return a value in function            array-callback-return

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.
rngadam commented 7 years ago

Warnings on the web console:

proxyConsole.js:56 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>. See App > p > ... > Test > div.
__stack_frame_overlay_proxy_console__ @ proxyConsole.js:56
proxyConsole.js:56 Warning: validateDOMNesting(...): <section> cannot appear as a descendant of <p>. See App > p > ... > Test > Reader > section.
__stack_frame_overlay_proxy_console__ @ proxyConsole.js:56
proxyConsole.js:56 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>. See App > p > ... > Test > SearchBar > div.
__stack_frame_overlay_proxy_console__ @ proxyConsole.js:56
proxyConsole.js:56 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>. See App > p > ... > Test > ItemDetail > div.
rngadam commented 7 years ago

I created https://github.com/coderbunker/inventory-app and gave you the rights on it.

suggest you do as follow:

cd inventory
git rm -fr -- cached inventory-app/
mv inventory-app ../
cd ../inventory-app 
git init
git add .
git commit -m "import from inventory branch"
git remote add origin git@github.com:coderbunker/inventory-app.git
git push -u origin master

and then, in inventory on your branch issue3-mvp do:

git commit -m "removal of inventory-app"
git rebase -i master

once you rebased, you can force push the new history:

git push -f

...and squash the removal so only the new QRcodes / page is left.