coderbunker / timesheet-dashboard-react

0 stars 0 forks source link

Display of monthly graph data is not sorted? #8

Closed rngadam closed 6 years ago

rngadam commented 6 years ago

After an update to the latest data, I'm getting months in seemingly random order:

screen shot 2018-07-22 at 6 10 17 pm

Maybe the GraphQL is missing an orderBy and the code is assuming the data is in order?

The data appears correctly in https://data.coderbunker.com

sam123evers commented 6 years ago

Fixed this by adding (orderBy: [ENTRY_YEAR_DESC, ENTRY_MONTH_DESC]) to the allMonthyGrosses query

How is looks now on my local machine:

screen shot 2018-07-24 at 5 40 11 pm

sam123evers commented 6 years ago

Hoping to get a reminder about how to make the production build live on dashboard.coderbunker.com

rngadam commented 6 years ago

Did you break the current release?

screen shot 2018-07-26 at 2 49 51 pm

Where's the pull request for this fix?

Why is there a PR on this repo that wasn't reviewed/merged first?

https://github.com/coderbunker/timesheet-dashboard-react/pull/7

rngadam commented 6 years ago

You pushed the whole master branch to gh-pages instead of just the public subdirectory which is why it broke.

That's also why you need a README.md in your projects with deployment instruction

sam123evers commented 6 years ago

Last time I did this I created a production build and deployed it I'm assuming I should repeat this process again to get is working? https://codeburst.io/deploy-react-to-github-pages-to-create-an-amazing-website-42d8b09cd4d article of steps I took was given to my by alex essentially on local gh-pages branch, running npm run build and then npm run deploy

sam123evers commented 6 years ago

Ok so running those commands brought the site back online but did not incorporate the orderBy fix

please advise

sam123evers commented 6 years ago

screen shot 2018-07-26 at 3 09 12 pm

rngadam commented 6 years ago

did you pull first?

rngadam commented 6 years ago

You had forgotten the part where you need to push the subdirectory, not the root. I just did.

document the other build steps in the README.md

You forgot the part where you need to push the subdirectory, not the root. I just did.

document the other build steps in the README.md

Fixed:

screen shot 2018-07-26 at 3 13 06 pm
rngadam commented 6 years ago

https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/