search

coderedcorp / django-sass

The absolute simplest way to use Sass with Django. Pure Python, minimal dependencies, no special configuration required!
Other
72 stars 7 forks source link

Pipeline fixes #6

Closed rcoldiron closed 3 years ago

rcoldiron commented 3 years ago

1) Fixed mypy typing errors and package finding error

20) Still working on pytest failures, which seem to be result of not recognizing python path or environment variables correctly. The 3 cli tests fail, use manage.py in a command, this is the error [file paths redacted]:

Traceback (most recent call last): File "****\testproject\manage.py", line 10, in main from django.core.management import execute_from_command_line ModuleNotFoundError: No module named 'django'

The above exception was the direct cause of the following exception:

Traceback (most recent call last): File "*\django-sass\testproject\manage.py", line 21, in main() File "** \testproject\manage.py", line 12, in main raise ImportError( ImportError: Couldn't import Django. Are you sure it's installed and available on your PYTHONPATH environment variable? Did you forget to activate a virtual environment?

I tried it in different python and django versions as well as different pytest-django and pytest versions and still get the error. EDIT: pytest all passes in the actual pipeline so not sure why it's failing when I run it locally. Maybe something with my virtual environment and not within the code itself??

rcoldiron commented 3 years ago

@vsalvino The only thing failing is Code Coverage now which is something you can fix? Anyway, this is ready for your review. Mypy and Pytest pass in the pipeline now.