search

coderedcorp / wagtail-seo

Search engine and social media optimization for Wagtail.
Other
66 stars 18 forks source link

Remove misleading help text for struct_org_logo #61

Closed Chadys closed 4 months ago

Chadys commented 4 months ago

Fix #59 remove misleading help text for struct_org_logo, remove with indication from schema doc.

vsalvino commented 4 months ago

Thanks for doing this! The tests are currently failing because the testproject needs a new migration.

In the testproject folder, create a venv, pip install requirements, then run: python manage.py makemigrations and commit that.

Chadys commented 4 months ago

Thanks for the explanation, didn't have time to look into it much but the error message seemed cryptic at first glance ^^ It's fixed!

Chadys commented 4 months ago

Spoke too soon, now the error is 

django.db.migrations.exceptions.NodeNotFoundError: Migration home.0004_alter_articlepage_struct_org_logo_and_more dependencies reference nonexistent parent node ('wagtailimages', '0026_delete_uploadedimage')

But only for tests on <=3.11, I suppose the wagtail version is different there. How do you want me to handle that? For a test app, I think removing the explicit dependency to newer wagtail migration won't hurt much.

vsalvino commented 4 months ago

To fix that, pip install the oldest supported version of wagtail (3.0.0), then delete and re-generate the migration.